From 27195d7dba0f3ff08b92f3fd916cdf5113cbef58 Mon Sep 17 00:00:00 2001 From: Chris Wilson Date: Wed, 31 Mar 2010 20:30:27 +0100 Subject: [PATCH] uxa: Try using put_image when copying from a memory buffer. Often, for example in the fallback for ShmPutImage, we will attempt to use uxa_copy_area() copying to a normal pixmap from a memory buffer. This triggers a fallback, and maps the destination pixmap back into the GTT. The accelerated put_image path will attempt to stream a blit to the destination pixmap if it is currently active, avoiding the stall. --- uxa/uxa-accel.c | 51 +++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 43 insertions(+), 8 deletions(-) diff --git a/uxa/uxa-accel.c b/uxa/uxa-accel.c index 7fb4bf98..c022956c 100644 --- a/uxa/uxa-accel.c +++ b/uxa/uxa-accel.c @@ -470,18 +470,19 @@ uxa_copy_n_to_n(DrawablePtr pSrcDrawable, goto fallback; } - if (!uxa_pixmap_is_offscreen(pSrcPixmap) || - !uxa_pixmap_is_offscreen(pDstPixmap) || - !(*uxa_screen->info->prepare_copy) (pSrcPixmap, pDstPixmap, + if (!uxa_pixmap_is_offscreen(pDstPixmap)) + goto fallback; + + if (uxa_pixmap_is_offscreen(pSrcPixmap)) { + if (!(*uxa_screen->info->prepare_copy) (pSrcPixmap, pDstPixmap, reverse ? -1 : 1, upsidedown ? -1 : 1, pGC ? pGC->alu : GXcopy, pGC ? pGC-> - planemask : FB_ALLONES)) { + planemask : FB_ALLONES)) goto fallback; - } - while (nbox--) { + while (nbox--) { (*uxa_screen->info->copy) (pDstPixmap, pbox->x1 + dx + src_off_x, pbox->y1 + dy + src_off_y, @@ -490,9 +491,43 @@ uxa_copy_n_to_n(DrawablePtr pSrcDrawable, pbox->x2 - pbox->x1, pbox->y2 - pbox->y1); pbox++; - } + } - (*uxa_screen->info->done_copy) (pDstPixmap); + (*uxa_screen->info->done_copy) (pDstPixmap); + } else { + int stride, bpp; + char *src; + + if (!uxa_screen->info->put_image) + goto fallback; + + /* Don't bother with under 8bpp, XYPixmaps. */ + bpp = pSrcPixmap->drawable.bitsPerPixel; + if (bpp != pDstDrawable->bitsPerPixel || bpp < 8) + goto fallback; + + /* Only accelerate copies: no rop or planemask. */ + if (pGC && (!UXA_PM_IS_SOLID(pSrcDrawable, pGC->planemask) || pGC->alu != GXcopy)) + goto fallback; + + src = pSrcPixmap->devPrivate.ptr; + stride = pSrcPixmap->devKind; + bpp /= 8; + while (nbox--) { + if (!uxa_screen->info->put_image(pDstPixmap, + pbox->x1 + dst_off_x, + pbox->y1 + dst_off_y, + pbox->x2 - pbox->x1, + pbox->y2 - pbox->y1, + (char *) src + + (pbox->y1 + dy + src_off_y) * stride + + (pbox->x1 + dx + src_off_x) * bpp, + stride)) + goto fallback; + + pbox++; + } + } return;