Aurelien
/
xf86-video-intel
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sna/damage: Always mark the damage as dirty when recording new boxes 

A few of the create_elts() routines missed marking the damage as dirty
so that if only part of the emebbed box was used (i.e. the damage
contained less than 8 rectangles that needed to included in the damage
region) then those were being ignored during migration and testing.

Reported-by: Clemens Eisserer <linuxhippy@gmail.com>
References: https://bugs.freedesktop.org/show_bug.cgi?id=44682
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
This commit is contained in:
Chris Wilson 2012-01-19 00:41:08 +00:00
parent 36e691ea90
commit 35f81005f9
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/sna/sna_damage.c
View File

@ -141,12 +141,12 @@ static const char *_debug_describe_damage(char *buf, int max,
damage->mode == DAMAGE_SUBTRACT ? '-' : '+');
} else
damage_str[0] = '\0';
snprintf(buf, max, "[[(%d, %d), (%d, %d)]: %s %s]",
snprintf(buf, max, "[[(%d, %d), (%d, %d)]: %s %s]%c",
damage->extents.x1, damage->extents.y1,
damage->extents.x2, damage->extents.y2,
_debug_describe_region(region_str, str_max,
&damage->region),
damage_str);
damage_str, damage->dirty ? '*' : ' ');
}
return buf;
@ -257,6 +257,7 @@ _sna_damage_create_elt_from_boxes(struct sna_damage *damage,
DBG((" %s: prev=(remain %d)\n", __FUNCTION__, damage->remain));
damage->dirty = true;
n = count;
if (n > damage->remain)
n = damage->remain;
@ -303,6 +304,7 @@ _sna_damage_create_elt_from_rectangles(struct sna_damage *damage,
DBG((" %s: prev=(remain %d), count=%d\n",
__FUNCTION__, damage->remain, count));
damage->dirty = true;
n = count;
if (n > damage->remain)
n = damage->remain;
@ -349,6 +351,7 @@ _sna_damage_create_elt_from_points(struct sna_damage *damage,
DBG((" %s: prev=(remain %d), count=%d\n",
__FUNCTION__, damage->remain, count));
damage->dirty = true;
n = count;
if (n > damage->remain)
n = damage->remain;