From 3f3bde4f0c72f6f31aae322bcdc20b95eade6631 Mon Sep 17 00:00:00 2001 From: Chris Wilson Date: Thu, 24 May 2012 11:58:46 +0100 Subject: [PATCH] uxa: Only consider an output valid if the kernel reports it attached Reported-by: Kyle Hill Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=50078 Signed-off-by: Chris Wilson --- src/intel_display.c | 22 ++++++++++++++++++++++ src/intel_driver.c | 20 -------------------- 2 files changed, 22 insertions(+), 20 deletions(-) diff --git a/src/intel_display.c b/src/intel_display.c index abdc372e..77a1cce1 100644 --- a/src/intel_display.c +++ b/src/intel_display.c @@ -1699,3 +1699,25 @@ int intel_crtc_to_pipe(xf86CrtcPtr crtc) struct intel_crtc *intel_crtc = crtc->driver_private; return intel_crtc->pipe; } + +Bool intel_crtc_on(xf86CrtcPtr crtc) +{ + ScrnInfoPtr scrn = crtc->scrn; + struct intel_crtc *intel_crtc = crtc->driver_private; + drmModeCrtcPtr drm_crtc; + Bool ret; + + if (!crtc->enabled) + return FALSE; + + /* Kernel manages CRTC status based on output config */ + drm_crtc = drmModeGetCrtc(intel_crtc->mode->fd, crtc_id(intel_crtc)); + if (drm_crtc == NULL) + return FALSE; + + ret = (drm_crtc->mode_valid && + intel_crtc->mode->fb_id == drm_crtc->buffer_id); + free(drm_crtc); + + return ret; +} diff --git a/src/intel_driver.c b/src/intel_driver.c index d67d8c8e..b0554374 100644 --- a/src/intel_driver.c +++ b/src/intel_driver.c @@ -782,26 +782,6 @@ intel_init_initial_framebuffer(ScrnInfoPtr scrn) return TRUE; } -Bool intel_crtc_on(xf86CrtcPtr crtc) -{ - ScrnInfoPtr scrn = crtc->scrn; - xf86CrtcConfigPtr xf86_config = XF86_CRTC_CONFIG_PTR(scrn); - int i; - - if (!crtc->enabled) - return FALSE; - - /* Kernel manages CRTC status based out output config */ - for (i = 0; i < xf86_config->num_output; i++) { - xf86OutputPtr output = xf86_config->output[i]; - if (output->crtc == crtc && - intel_output_dpms_status(output) == DPMSModeOn) - return TRUE; - } - - return FALSE; -} - static void intel_flush_callback(CallbackListPtr *list, pointer user_data, pointer call_data)