From 660e9e14bd49fad75dd2fd73c285e035e2672da4 Mon Sep 17 00:00:00 2001 From: Chris Wilson Date: Wed, 2 Oct 2013 15:01:53 +0100 Subject: [PATCH] sna: Add a few more asserts around handling of buffers Signed-off-by: Chris Wilson --- src/sna/kgem.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/sna/kgem.c b/src/sna/kgem.c index 9685fb34..81ca65ef 100644 --- a/src/sna/kgem.c +++ b/src/sna/kgem.c @@ -2407,7 +2407,7 @@ static void kgem_finish_buffers(struct kgem *kgem) } if (bo->mmapped) { - int used; + uint32_t used; assert(!bo->need_io); @@ -2417,6 +2417,7 @@ static void kgem_finish_buffers(struct kgem *kgem) (kgem->has_llc || bo->mmapped == MMAPPED_GTT || bo->base.snoop)) { DBG(("%s: retaining upload buffer (%d/%d)\n", __FUNCTION__, bo->used, bytes(&bo->base))); + assert(used >= bo->used); bo->used = used; list_move(&bo->base.list, &kgem->active_buffers); @@ -5985,6 +5986,7 @@ init: done: bo->used = ALIGN(bo->used, UPLOAD_ALIGNMENT); + assert(bo->used && bo->used <= bytes(&bo->base)); assert(bo->mem); *ret = (char *)bo->mem + offset; return kgem_create_proxy(kgem, &bo->base, offset, size);