From 790f90a277ff2a6fbb615b8cd3c06faa0d549c41 Mon Sep 17 00:00:00 2001 From: Chris Wilson Date: Tue, 7 Jun 2011 08:18:30 +0100 Subject: [PATCH] sna/gen6: Initialise a couple more composite op members for copy_boxes Valgrind detected that I missed initialised a couple of fields for use with the generic state emission paths: ==28683== Conditional jump or move depends on uninitialised value(s) ==28683== at 0x83BE646: gen6_get_blend (gen6_render.c:251) ==28683== by 0x83BF769: gen6_emit_state (gen6_render.c:818) ==28683== by 0x83C38ED: gen6_emit_copy_state (gen6_render.c:2280) ==28683== by 0x83C3C89: gen6_render_copy_boxes (gen6_render.c:2356) ==28683== Conditional jump or move depends on uninitialised value(s) ==28683== at 0x83C15C3: gen6_rectangle_begin (gen6_render.c:1458) ==28683== by 0x83C177D: gen6_get_rectangles (gen6_render.c:1502) ==28683== by 0x83C3D16: gen6_render_copy_boxes (gen6_render.c:2363) Signed-off-by: Chris Wilson --- src/sna/gen6_render.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/sna/gen6_render.c b/src/sna/gen6_render.c index 56aaadcc..1cc30b20 100644 --- a/src/sna/gen6_render.c +++ b/src/sna/gen6_render.c @@ -2339,6 +2339,8 @@ gen6_render_copy_boxes(struct sna *sna, uint8_t alu, tmp.is_affine = TRUE; tmp.floats_per_vertex = 3; + tmp.has_component_alpha = 0; + tmp.need_magic_ca_pass = 0; tmp.u.gen6.wm_kernel = GEN6_WM_KERNEL_NOMASK; tmp.u.gen6.nr_surfaces = 2;