From bccbbf8a68faf7aac274efd289d4916083b1a1e3 Mon Sep 17 00:00:00 2001 From: Chris Wilson Date: Tue, 22 Oct 2013 14:22:14 +0100 Subject: [PATCH] sna: Remove the move-to-gpu shortcircuiting for partial GPU, no CPU damage Otherwise we may not correctly undo COW or pending move-to-gpu updates. Signed-off-by: Chris Wilson --- src/sna/sna_accel.c | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/src/sna/sna_accel.c b/src/sna/sna_accel.c index fc99a7d2..954d2345 100644 --- a/src/sna/sna_accel.c +++ b/src/sna/sna_accel.c @@ -3402,21 +3402,8 @@ create_gpu_bo: if (priv->gpu_damage) { assert(priv->gpu_bo); - if (!priv->cpu_damage) { - if (sna_damage_contains_box__no_reduce(priv->gpu_damage, - ®ion.extents)) { - DBG(("%s: region wholly contained within GPU damage\n", - __FUNCTION__)); - assert(sna_damage_contains_box(priv->gpu_damage, ®ion.extents) == PIXMAN_REGION_IN); - assert(sna_damage_contains_box(priv->cpu_damage, ®ion.extents) == PIXMAN_REGION_OUT); - goto use_gpu_bo; - } else { - DBG(("%s: partial GPU damage with no CPU damage, continuing to use GPU\n", - __FUNCTION__)); - priv->cpu = false; - goto done; - } - } + if (!priv->cpu_damage) + goto use_gpu_bo; ret = sna_damage_contains_box(priv->gpu_damage, ®ion.extents); if (ret == PIXMAN_REGION_IN) {