Aurelien
/
xf86-video-intel
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "sna: Close each client op with an arbitrartion check" 

This reverts commit b5ac286c9b as it escaped before being completed.
It proved it's worth in preventing sna from hogging the GPU for too long
under x11perf stress, but it didn't check to see if there was enough
space left in the batch before emitting the dword. Simply revert the
patch for now.

Reported-by: Matti Hämäläinen <ccr@tnsp.org>
Closes: https://gitlab.freedesktop.org/xorg/driver/xf86-video-intel/issues/174
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
This commit is contained in:
Chris Wilson 2019-12-09 14:39:40 +00:00
parent 0867eea666
commit d90a2ff1a6
3 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/sna/sna_accel.c
View File

@ -5302,8 +5302,6 @@ inline static void blt_done(struct sna *sna)
DBG(("%s: flushing BLT operation on empty ring\n",
__FUNCTION__));
_kgem_submit(&sna->kgem);
} else {
sna->kgem.batch[sna->kgem.nbatch++] = MI_ARB_CHECK;
}
}

1
src/sna/sna_reg.h
View File

@ -14,7 +14,6 @@
/* broadwater flush bits */
#define BRW_MI_GLOBAL_SNAPSHOT_RESET (1 << 3)
#define MI_ARB_CHECK (0x5 << 23)
#define MI_BATCH_BUFFER_END (0xA << 23)
/* Noop */

3
src/sna/sna_render.c
View File

@ -32,7 +32,6 @@
#include "sna.h"
#include "sna_render.h"
#include "sna_render_inline.h"
#include "sna_reg.h"
#include "fb/fbpict.h"
#define NO_REDIRECT 0
@ -2130,8 +2129,6 @@ sna_render_composite_redirect_done(struct sna *sna,
kgem_bo_destroy(&sna->kgem, op->dst.bo);
}
batch_emit(sna, MI_ARB_CHECK);
}
static bool