Aurelien
/
xf86-video-intel
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sna/traps: Align indices for unrolled memset in row_inplace() 

The compiler presumes that the uint64_t write is naturally aligned and
so may emit code that crashes with an unaligned moved. To workaround
this, make sure the write is so aligned.

References: https://bugs.freedesktop.org/show_bug.cgi?id=47418
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
This commit is contained in:
Chris Wilson 2012-03-17 09:21:00 +00:00
parent 2b4e11923d
commit e31d9dacaf
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/sna/sna_trapezoids.c
View File

@ -1499,6 +1499,21 @@ inplace_row(struct active_list *active, uint8_t *row, int width)
else
memset(row+lix, 0xff, rix);
#else
if (lix & 1 && rix) {
row[lix] = 0xff;
lix++;
rix--;
}
if (lix & 2 && rix >= 2) {
*(uint16_t *)(row+lix) = 0xffff;
lix += 2;
rix -= 2;
}
if (lix & 4 && rix >= 4) {
*(uint32_t *)(row+lix) = 0xffffffff;
lix += 4;
rix -= 4;
}
while (rix >= 8) {
*(uint64_t *)(row+lix) = 0xffffffffffffffff;
lix += 8;