From e7016d30f3a0ae817c77ccbd962f776ac3e7e100 Mon Sep 17 00:00:00 2001 From: Olivier Fourdan Date: Wed, 29 Apr 2015 10:33:19 +0100 Subject: [PATCH] backlight: Do not hang forever if helper pid is -1 Backlight helper PID is set to -1 by default, if for some reason it's not set, we may end up with waitpid(-1, ...) which will hang forever. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90230 Signed-off-by: Olivier Fourdan --- src/backlight.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backlight.c b/src/backlight.c index 84d8f761..c65e466b 100644 --- a/src/backlight.c +++ b/src/backlight.c @@ -523,7 +523,7 @@ void backlight_disable(struct backlight *b) void backlight_close(struct backlight *b) { backlight_disable(b); - if (b->pid) + if (b->pid > 0) waitpid(b->pid, NULL, 0); }