Aurelien
/
xf86-video-intel
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sna/dri2: Prevent copying stale buffers 

The back buffer of window/pixmap is invalidated by DRI2ScheduleSwap, and
is not available until the client calls DRI2GetBuffers. If they try to
use their old handles, they will only get stale data. Similarly if they
ask us to DRI2CopyRegion before the GetBuffers has reallocated a new
back buffer, that back buffer is stale. Since the back buffer is
out-of-date [likely containing data from a couple of swaps ago], we
should ignore the copy to avoid glitching [by hopefully having a less
noticeable glitch!] It's not entirely clear what the client intended at
this point...

Closes: https://gitlab.freedesktop.org/xorg/driver/xf86-video-intel/-/issues/195
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
This commit is contained in:
Chris Wilson 2020-05-06 18:56:39 +01:00
parent 846b53dacd
commit e781d43dad
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/sna/sna_dri2.c
View File

@ -1421,25 +1421,30 @@ sna_dri2_copy_region(DrawablePtr draw,
PixmapPtr pixmap = get_drawable_pixmap(draw);
struct sna *sna = to_sna_from_pixmap(pixmap);
DBG(("%s: pixmap=%ld, src=%u (refs=%d/%d, flush=%d, attach=%d) , dst=%u (refs=%d/%d, flush=%d, attach=%d)\n",
DBG(("%s: pixmap=%ld, src=%u (attach=%d, refs=%d/%d, flush=%d, stale=%d) , dst=%u (attach=%d, refs=%d/%d, flush=%d, stale=%d)\n",
__FUNCTION__,
pixmap->drawable.serialNumber,
get_private(src)->bo->handle,
src->attachment,
get_private(src)->refcnt,
get_private(src)->bo->refcnt,
get_private(src)->bo->flush,
src->attachment,
get_private(src)->stale,
get_private(dst)->bo->handle,
dst->attachment,
get_private(dst)->refcnt,
get_private(dst)->bo->refcnt,
get_private(dst)->bo->flush,
dst->attachment));
get_private(dst)->stale));
assert(src != dst);
assert(get_private(src)->refcnt);
assert(get_private(dst)->refcnt);
if (get_private(src)->stale)
return;
assert(get_private(src)->bo != get_private(dst)->bo);
assert(get_private(src)->bo->refcnt);