From f66d39544bb8339130c96d282a80f87ca1606caf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= Date: Mon, 9 Dec 2019 17:01:36 +0200 Subject: [PATCH] sna: Fix dirtyfb detection MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix the accidentally swapped bpp and depth values passed to the addfb ioctl when we're testing for dirtyfb presence. Currently the addfb fails every time so we don't even test the actual dirtyfb ioctl. Signed-off-by: Ville Syrjälä Reviewed-by: Chris Wilson --- src/sna/kgem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sna/kgem.c b/src/sna/kgem.c index 9c0708a6..6a35067c 100644 --- a/src/sna/kgem.c +++ b/src/sna/kgem.c @@ -1538,8 +1538,8 @@ static bool test_has_dirtyfb(struct kgem *kgem) create.width = 32; create.height = 32; create.pitch = 4*32; - create.bpp = 24; - create.depth = 32; /* {bpp:24, depth:32} -> x8r8g8b8 */ + create.bpp = 32; + create.depth = 24; /* {bpp:32, depth:24} -> x8r8g8b8 */ create.handle = gem_create(kgem->fd, 1); if (create.handle == 0) return false;