The operations when setting dpms on should be in the order opposite
of what's done when setting dpms off.
This is because of potentially conflicting effects:
~ drmModeConnectoSetProperty() enables/disables the backlight driver.
Some backlight drivers such as intel_backlight set the backlight to 0
when disabled and to max when enabled.
~ intel_output_dpms_backlight() saves the backlight value when turning
DPMS off and restores it when turning DPMS on.
Here's the current order of operations:
xset dpms force off (backlight is nonzero)
drmModeConnectoSetProperty(DPMSModeOff)
kernel: disable backlight, backlight=0
intel_output_dpms_backlight(DPMSModeOff)
save backlight value (0) <-- it has been set to 0 by kernel
set backlight to 0
xset dpms force on
drmModeConnectoSetProperty(DPMSModeOn)
kernel: enable backlight, backlight=max
intel_output_dpms_backlight(DPMSModeOn)
set backlight to saved value (0)
The correct way to do this would be to reverse the operations during
xset dpms force off:
intel_output_dpms_backlight(DPMSModeOff)
save backlight value (nonzero)
set backlight to 0
drmModeConnectoSetProperty(DPMSModeOff)
kernel: enable backlight, backlight=0
This restores the saved nonzero backlight value during the force on.
Signed-off-by: Simon Que <sque@chromium.org>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
|
||
|---|---|---|
| m4 | ||
| man | ||
| src | ||
| test | ||
| uxa | ||
| .gitignore | ||
| AUTHORS | ||
| COPYING | ||
| Makefile.am | ||
| NEWS | ||
| README | ||
| RELEASING | ||
| autogen.sh | ||
| configure.ac | ||
README
xf86-video-intel Open-source X.org graphics driver for Intel graphics http://www.intellinuxgraphics.com/ What is xf86-video-intel ------------------------ The xf86-video-intel module is an open-source 2D graphics driver for the X Window System as implemented by X.org. It supports a variety of Intel graphics chipsets including: i810/i810e/i810-dc100,i815, i830M,845G,852GM,855GM,865G, 915G/GM,945G/GM/GME,946GZ G/GM/GME/Q965, G/Q33,G/Q35,G41,G/Q43,G/GM/Q45 PineView-M (Atom N400 series) PineView-D (Atom D400/D500 series) Where to get more information about the driver ---------------------------------------------- The primary source of information about this and other open-source drivers for Intel graphics is: http://intellinuxgraphics.org/ Documentation specific to the xf86-video-intel driver including possible configuration options for the xorg.conf file can be found in the intel(4) manual page. After installing the driver this documentation can be read with the following command: man intel Mailing list for communication with users and developers of xf86-video-intel: intel-gfx@lists.freedesktop.org Note: Subscription is required before posting, but anyone is free to subscribe. See instructions (and archives) here: http://lists.freedesktop.org/mailman/listinfo/intel-gfx To report bugs encountered with the driver, see: http://intellinuxgraphics.org/how_to_report_bug.html To see bugs that are targeted to be fixed in the next release: https://bugs.freedesktop.org/show_bug.cgi?id=intel-2d-release