From 6cace4990abc2386b6ea68536b321994d264c295 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Louis-Francis=20Ratt=C3=A9-Boulianne?= Date: Thu, 26 Apr 2018 11:04:15 -0400 Subject: [PATCH] modesetting: Fix GBM objects leak when checking for flip MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit GBM objects were never destroyed after looking for format and modifier compatibility when deciding whether flipping or copying a presented pixmap. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106106 Signed-off-by: Louis-Francis Ratté-Boulianne --- hw/xfree86/drivers/modesetting/present.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/xfree86/drivers/modesetting/present.c b/hw/xfree86/drivers/modesetting/present.c index 9be8efe4ff..dda7cc064d 100644 --- a/hw/xfree86/drivers/modesetting/present.c +++ b/hw/xfree86/drivers/modesetting/present.c @@ -263,6 +263,8 @@ ms_present_check_flip(RRCrtcPtr crtc, format = gbm_bo_get_format(gbm); modifier = gbm_bo_get_modifier(gbm); + gbm_bo_destroy(gbm); + if (!drmmode_is_format_supported(scrn, format, modifier)) { if (reason) *reason = PRESENT_FLIP_REASON_BUFFER_FORMAT;