This fixes an issue with us claiming Poulsbo and friends even though we
do not speak their language.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
As __sna_render_pixmap_bo() deliberately does not reference its returned
bo, we need to avoid unreferencing it else we cause explosions later.
Fixes regression from commit a13781d19d
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Sun Aug 19 09:45:12 2012 +0100
sna: Enable BLT composite functions to target CPU buffers
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
As we end up submitting and maybe synchronising upon a batch within
FlushCallback (or our client will) it is important that we start that
serialized batch as early as possible to minimise the impending stalls.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Fixes regression in 2.20.4 from
commit 85192f00e3
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Wed Aug 8 12:11:50 2012 +0100
sna: Ignore trailing bits when comparing lines inside the bitmap
Reported-by: Edward Sheldrake <ejsheldrake@gmail.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=53699
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
sna_accel.c: In function 'sna_poly_fill_rect_extents':
sna_accel.c:11438:11: warning: unused variable 'v' [-Wunused-variable]
sna_blt.c: In function 'sna_blt_composite__convert':
sna_blt.c:1712:3: warning: format '%s' expects a matching 'char *' argument [-Wformat]
sna_blt.c:1738:3: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'CARD32' [-Wformat]
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
This is only test code, so keep the static analyser quiet
Reported-by: Zdenek Kabelac <zkabelac@redhat.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
The fall-through in this instance is irrelevant, and the static
analysers complain for not commenting on the fall-through. Silence the
analyser by removing the fall-through.
Reported-by: Zdenek Kabelac <zkabelac@redhat.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
If the pipe is not running, attempting to queue a pageflip will result
in an error and us disabling the output in retaliation.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
If the flip fail, we disable the crtc and may end up disabling the
output, removing the shadow (and old scanout bo) in the process.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
The midlayer has already detached the pixmap from the segment (possibly
destroying that segment in the process, thanks midlayer!) so we need to
submit the batch asap before the segment disappears.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Some applications like to waste precious bw by attempting to fill
zero-sized rectangles; remove them upfront rather than process them.
Reported-by: Jiri Slaby <jirislaby@gmail.com>
References: https://bugs.freedesktop.org/show_bug.cgi?id=47597
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
A little too overzealous in the degradation of writing to the CPU bo
if we need to read from a GPU bo.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
If the pixmap is less than a page in size we are unlikely to recover the
cost of tracking it via the GPU.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Chris Wilson