Commit Graph

5275 Commits

Author SHA1 Message Date
Chris Wilson b8bc56c12c uxa/gen3: Simply simple fill shader generation
Suggested-by: Zdenek Kabelac <zkabelac@redhat.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-16 21:00:57 +01:00
Chris Wilson c289b607d1 uxa: Check for failed mmapping of the scanout
Reported-by: Zdenek Kabelac <zkabelac@redhat.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-16 20:54:53 +01:00
Chris Wilson 5675c36e0d sna: Check for failure to pin the front buffer
Reported-by: Zdenek Kabelac <zkabelac@redhat.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-16 20:44:32 +01:00
Chris Wilson c9db2c74ab sna/gen2: Add break rather than fallthrough
The fall-through in this instance is irrelevant, and the static
analysers complain for not commenting on the fall-through. Silence the
analyser by removing the fall-through.

Reported-by: Zdenek Kabelac <zkabelac@redhat.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-16 20:42:50 +01:00
Chris Wilson e0abbc3cca i810: Query PortPriv for the surface properties
Avoid the NULL deferences.

Reported-by: Zdenek Kabelac <zkabelac@redhat.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-16 20:40:17 +01:00
Chris Wilson c09518f98d sna: Fix assignment inside assertion (should be an equality check)
Reported-by: Zdenek Kabelac <zkabelac@redhat.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-16 20:32:53 +01:00
Chris Wilson 7d3e4328d4 sna/glyphs: Fix potential leak of glyph extents (for many lists of many formats)
Reported-by: Zdenek Kabelac <zkabelac@redhat.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-16 20:32:11 +01:00
Chris Wilson 9b00c82df7 sna: Remember alpha-fixup for BLT upload
Still dubious whether this is truly beneficial...

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-16 20:30:52 +01:00
Chris Wilson 94871944a0 sna: Avoid conflating tearfree and randr shadow modes
For ordinary TearFree we do not want to adjust the crtc offsets.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-16 00:12:14 +01:00
Chris Wilson 1a38984234 sna: Avoid queuing a pageflip on a DPMS off pipe
If the pipe is not running, attempting to queue a pageflip will result
in an error and us disabling the output in retaliation.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-15 23:07:16 +01:00
Chris Wilson 615739556d sna: Only continue to update the shadow buffer if the flips succeeded
If the flip fail, we disable the crtc and may end up disabling the
output, removing the shadow (and old scanout bo) in the process.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-15 20:10:52 +01:00
Chris Wilson 2554d0d76e sna: Submit the batch upon destroying a ShmPixmap
The midlayer has already detached the pixmap from the segment (possibly
destroying that segment in the process, thanks midlayer!) so we need to
submit the batch asap before the segment disappears.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-15 18:04:18 +01:00
Chris Wilson 4e604d721b sna: Flush shm pixmaps after upload
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-15 16:53:20 +01:00
Chris Wilson 7f5a9e30c9 sna: Remove zero-size rectangles fro PolyFillRectangle
Some applications like to waste precious bw by attempting to fill
zero-sized rectangles; remove them upfront rather than process them.

Reported-by: Jiri Slaby <jirislaby@gmail.com>
References: https://bugs.freedesktop.org/show_bug.cgi?id=47597
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-15 09:46:54 +01:00
Chris Wilson 0c882f4fa9 sna/gen2,3: Prevent dereferencing a NULL bo with solid render fills
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-14 16:02:38 +01:00
Chris Wilson 48f436d370 sna: Defer the release of a busy SHM pixmap until the next flush callback
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-14 15:06:27 +01:00
Chris Wilson 9f07d1fc01 sna: Enable use of shm pixmap for readback
A little too overzealous in the degradation of writing to the CPU bo
if we need to read from a GPU bo.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-14 12:03:24 +01:00
Chris Wilson 9b016d2e46 sna: do not bother attaching to a miniscule ShmPixmap
If the pixmap is less than a page in size we are unlikely to recover the
cost of tracking it via the GPU.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-12 22:06:48 +01:00
Chris Wilson 2f4de90709 uxa: Only emit a warning if we fail to tile the frontbuffer and the hw allows
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-12 13:02:27 +01:00
Chris Wilson 4d3cafc99a sna: Fix compilation without pixman glyphs
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-12 13:02:43 +01:00
Chris Wilson dc18eaa585 sna: Make the failure to create render caches non-fatal
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-12 12:05:43 +01:00
Dave Airlie b580abdfa6 intel: fix video xvPipe range check
Pointed out by Russell King on irc.

Signed-off-by: Dave Airlie <airlied@redhat.com>
2012-08-12 20:52:12 +10:00
Chris Wilson 44f848f9b2 sna: Fix typo in computation of texel offsets for tiled 8x8 blts
Reported-by: Clemens Eisserer <linuxhippy@gmail.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=53353
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-11 19:44:15 +01:00
Chris Wilson b335d369bb sna: Discard the GPU bo after syncing to CPU bo for writing
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-11 13:59:31 +01:00
Chris Wilson 029934662e sna: Add a little DBG for promotion of CPU source bo
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-11 11:12:33 +01:00
Chris Wilson f20f8556bf sna: Treat ShmPixmap as ordinary
In theory the code handles the automatic promotion and demotion of the
GPU buffers.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-11 11:12:33 +01:00
Chris Wilson 16c751a06c sna: Only mark userptr bo as snooped on non-LLC architectures
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-11 11:12:33 +01:00
Chris Wilson 59359dba64 sna: Mark SHM userptr bo as unreusable
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-11 11:12:33 +01:00
Chris Wilson 6448801050 sna/gen2-5: Substitute an equivalent BLT composite operation
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-11 11:12:33 +01:00
Chris Wilson f464d508c8 sna/gen6+: Try to use the BLT to avoid TLB misses
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-11 11:12:33 +01:00
Chris Wilson e9c0e54e69 sna: Handle userptr failures more gracefully
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-11 11:12:33 +01:00
Chris Wilson 5d6d9231cd sna: Reset BLT state after copy-boxes
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-10 23:07:07 +01:00
Chris Wilson 50bfc172f1 sna: Improve a DBG statement
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-10 22:49:26 +01:00
Chris Wilson b33f6754a9 sna: Add assertions to 8x8 tiled BLTs and reset BLT state afterwards
Reported-by: Clemens Eisserer <linuxhippy@gmail.com>
References: https://bugs.freedesktop.org/show_bug.cgi?id=53353
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-10 22:01:23 +01:00
Chris Wilson ff54d4af39 sna: Add a couple of debug options to control use of BLT patterns
References: https://bugs.freedesktop.org/show_bug.cgi?id=53353
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-10 21:41:38 +01:00
Chris Wilson 2230614403 sna: Use the HAS_SEMAPHORES parameter when available
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-08 19:45:09 +01:00
Chris Wilson 465ae1840a sna: Use a compile time constant for determine the zeroth bit
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-08 12:24:17 +01:00
Chris Wilson 85192f00e3 sna: Ignore trailing bits when comparing lines inside the bitmap
References: https://bugs.freedesktop.org/show_bug.cgi?id=51422
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-08 12:18:48 +01:00
Chris Wilson edc1427f3d sna/gen5: Add DBG for context switching
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-08 10:53:40 +01:00
Chris Wilson fec78ddc60 sna: Add DBG option to disable discarding of glyph masks
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-08 10:08:52 +01:00
Chris Wilson b0cd430082 sna/gen5: Fix use of uninitialised rgba value for DBG
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-08 10:07:06 +01:00
Chris Wilson 9ad923f95c sna: Minor DBG for fallback glyphs and discarding the mask
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-08 09:59:50 +01:00
Chris Wilson 1a0590d133 sna: Check the composite extents against the clip
When computing the composite extents (as opposed to the composite
region) also check if the resultant box overlaps the destination clip
region (we know it already fits into the extents). This helps in cases
with small roi against clipped drawables, such as drawing text onto
expose events.

References: https://bugs.freedesktop.org/show_bug.cgi?id=51422
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-07 17:19:52 +01:00
Paulo Zanoni 5f5a10ef04 Add Haswell PCI IDs
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-07 11:35:19 +01:00
Chris Wilson d8f7f933bc sna: Format markup to suppress compiler warning
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-05 17:18:54 +01:00
Chris Wilson 4d0a259988 sna/gen6: Compile fix for DBG
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-05 11:03:40 +01:00
Chris Wilson d917a276bf sna/gen4: Restore the w/a flush for fill/copy as well
So far, it looks like that the only one we can indeed drop is the
composite with mask.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-04 18:05:03 +01:00
Cyril Brulebois d754bc3435 Fix build failure when passing --with-builderstring.
If --with-builderstring="foo" is passed to configure (and sna enabled):
  CC     sna_driver.lo
src/sna/sna_driver.c: In function 'sna_init_scrn':
src/sna/sna_driver.c:1023:7: error: token ""foo"" is not valid in preprocessor expressions

Fix the missing defined() around the BUILDER_DESCRIPTION variable.

Signed-off-by: Cyril Brulebois <kibi@debian.org>
2012-08-04 16:35:58 +01:00
Chris Wilson 4bad76b451 sna/dri: Don't force ring selection if we have semaphores
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-04 14:32:04 +01:00
Chris Wilson fb7b584ec9 sna/dri: Correct ring selection for a busy bo
Confused the RENDER ring with the BLT, limiting swap performance.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
2012-08-04 14:32:04 +01:00